Learn New MQL Coding

struct MyStruct  {
   int m_Member;  
};

class MyClass {
   int m_Member;  
};

class MyClass {
   public:
      int m_Member;  
};

class MyClass {
   private:
      int m_PrivateMember;
   protected:
      int m_ProtectedMember;
   public :
      int PublicMethod();     // A function in a class is called a method.
};

class MyClass {
   private:
      int m_PrivateMember;
    
   protected:
      int m_ProtectedMember;
    
   public:
       MyClass();
      ~MyClass();
};

class MyMovingAverage {
   private:
      int   m_Period;
    
   public:
            MyMovingAverage( int period );
      void  Compute( const int total_rates, const int prev_calcd, const double& price[], double& output[] );
};

MyMovingAverage::MyMovingAverage( int period ){
   m_Period = period;
}

void MyMovingAverage::Compute( const int totalrates, const int prevcalcd, const double& price[], double& out[] ) {
 
   int i, Start;
  
   // If there are not enough rates,
   // i.e less than desired period, we just return.
   if( totalrates <= m_Period ) {
      return;
   }
  
   if( prevcalcd == 0 ) {
      Start = m_Period;
      // Calculate first visible value.
      double FirstValue=0;
      for( i=0; i<Start; i++ ){
         FirstValue += price[i];
      }
      FirstValue /= m_Period;
      out[Start-1] = FirstValue;
   }
   else {
      Start = prevcalcd - 1;
   }
 
   for( i=Start; i<totalrates && !IsStopped(); i++ ) {
      out[i] = out[i-1] + (price[i]-price[i-m_Period]) / m_Period;
   }
}

#include <MyMovingAverage.mqh>

MyMovingAverage*                    MyMA;

int OnInit() {
…
MyMA = new MyMovingAverage( MAPeriod );
return INIT_SUCCEEDED;
}

int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
{
  
   ArraySetAsSeries( MainBuffer, true );
   ArraySetAsSeries( close, true );
 
   MyMA.Compute( rates_total, prev_calculated, close, MainBuffer );
  
  
   // Return number of calculated rates.
   return(rates_total);
  
}

Quoting khanahesan

Disliked

Hello all my dear traders, I have a indicator name SDXTZPivot (attached below). In this indicator there are few more pivot rather than just pivot point from that I just like to use fibo pivot. When I choose the option of fibo pivot it shows fibo pivot along with text so is there any one who remove all that text and first vertical line from that indicator. English is not my mother tongue so I have attaching a picture also for your understanding. Thanks... {file} {image}

Ignored

Quoting Gumrai

Disliked

Thank You BrokeTrader. But I guess that I am just too stupid to understand. Your recent posts have not been "Dumbed down" enough for me, so I have no idea what you are talking about. Please keep up the good work as I am sure that everyone is not as stupid as me. I will continue to follow and hopefully manage to learn something.

Ignored

Quoting broketrader

Disliked

{quote} OOP offers many advantages like organizing your code in objects that reflect and have their own life.

Ignored

Quoting Gumrai

Disliked

{quote} That may be one of my problems. With using the old mql4 code, I am conditioned that when talking about objects, we are referring to trend-lines, labels, rectangles etc. I think that objects in OOP has a different definition

Ignored

Quoting fx01

Disliked

Nice thread, broketrader. I recently learned MQL4 (after 600 build) from book.mql4.com . It was a pain to fix errors and warnings because book.mql4.com didn't update their content. It was very easy to learn as i already knew few programming languages. This thread is definitely going to be helpful for newbies.. Even though i already learned this, i am going to keep eye on this thread to improve my skills..

Ignored

Quoting fx01

Disliked

Nice thread, broketrader. I recently learned MQL4 (after 600 build) from book.mql4.com . It was a pain to fix errors and warnings because book.mql4.com didn't update their content. It was very easy to learn as i already knew few programming languages. This thread is definitely going to be helpful for newbies.. Even though i already learned this, i am going to keep eye on this thread to improve my skills..

Ignored

void Compute( const ENUM_MA_METHOD method, const int total_rates, const int prev_calcd, const double& price[], double& output[] ){
  switch( method ){
    case MODE_SMA : ComputeSma( total_rates, prev_calcd, price, output ); break;
    case MODE_EMA : ComputeEma( ... ); break;
  }
};

class Shape {
   public :
      virtual void Draw();
};

class Circle : public Shape {
   public :
      void Draw();
};

// Instantiate each graphical object.
Shape* MyCircle = new Circle();
Shape* MyTriangle = new Triangle();
Shape* MyRectangle = new Rectangle();

void DrawObject( Shape* shape ){
  shape.Draw();
}

string ConvertToString( double value, int digits );
string ConvertToString( int value );

class MyMovingAverage {
  
   protected:
  
      int            m_Period;
    
   public:
  
                     MyMovingAverage( int period );
      virtual void   Compute( const int total_rates, const int prev_calcd, const double& price[], double& output[] ){} ;
};

class MySimpleMovingAverage : public MyMovingAverage {
 
   public :
            MySimpleMovingAverage( const int period );
      void  Compute( const int total_rates, const int prev_calcd, const double& price[], double& output[] );
};

MySimpleMovingAverage::MySimpleMovingAverage( int period ) : MyMovingAverage( period ){
}

void MySimpleMovingAverage::Compute( const int totalrates, const int prevcalcd, const double& price[], double& out[] ) {
 
   int i, Start;
  
   // If there are not enough rates,
   // i.e less than desired period, we just return.
   if( totalrates <= m_Period ) {
      return;
   }
  
   if( prevcalcd == 0 ) {
      Start = m_Period;
      // Calculate first visible value.
      double FirstValue=0;
      for( i=0; i<Start; i++ ){
         FirstValue += price[i];
      }
      FirstValue /= m_Period;
      out[Start-1] = FirstValue;
   }
   else {
      Start = prevcalcd - 1;
   }
 
   for( i=Start; i<totalrates && !IsStopped(); i++ ) {
      out[i] = out[i-1] + (price[i]-price[i-m_Period]) / m_Period;
   }
}

int OnInit() {
   IndicatorBuffers( 1 );                    // We have only one indicator
   IndicatorDigits( Digits );                // Digits showwhen visualizing indicator value.
   SetIndexStyle( 0, DRAW_LINE );            // MA shown as a simple line
   SetIndexBuffer( 0, MainBuffer );          // Associate buffer to index.
   SetIndexShift( 0, MAShift );              // Apply user shift
   SetIndexLabel( 0, "MyMovingAverage" );    // Index Label
   ArrayInitialize( MainBuffer ,0);          // Initializes the array
 
   // Check that input parameter is valid
   if( MAPeriod <= 0 ) {
      Print( "Wrong input parameter MAPeriod" );
      return INIT_FAILED;
   }
  
   // Instantiate indicator objects
   MyMA = new MySimpleMovingAverage( MAPeriod );
  
   return INIT_SUCCEEDED;
}

int OnInit() {
   IndicatorBuffers( 1 );                    // We have only one indicator
   IndicatorDigits( Digits );                // Digits showwhen visualizing indicator value.
   SetIndexStyle( 0, DRAW_LINE );            // MA shown as a simple line
   SetIndexBuffer( 0, MainBuffer );          // Associate buffer to index.
   SetIndexShift( 0, MAShift );              // Apply user shift
   SetIndexLabel( 0, "MyMovingAverage" );    // Index Label
   ArrayInitialize( MainBuffer ,0);          // Initializes the array
 
   // Check that input parameter is valid
   if( MAPeriod <= 0 ) {
      Print( "Wrong input parameter MAPeriod" );
      return INIT_FAILED;
   }
  
   // Instantiate indicator objects
   switch( MAMethod ) {
      case MODE_SMA: MyMA = new MySimpleMovingAverage( MAPeriod ); break;
      case MODE_EMA: MyMA = new MyExponentialMovingAverage( MAPeriod ); break;
      // Other types not yet implemented
   }
  
  
   return INIT_SUCCEEDED;
}

const int                           FastMaPlotIndex   = 0;
input int                           FastMaPeriod      = 20;
input int                           FastMaShift       = 0;
input ENUM_MA_METHOD                FastMaMethod      = MODE_SMA;
input ENUM_APPLIED_PRICE            FastMaPrice       = PRICE_CLOSE;
const string                        FastMaLabel       = "FastMa";
 
const int                           SlowMaPlotIndex   = 1;
input int                           SlowMaPeriod      = 50;
input int                           SlowMaShift       = 0;
input ENUM_MA_METHOD                SlowMaMethod      = MODE_SMA;
input ENUM_APPLIED_PRICE            SlowMaPrice       = PRICE_CLOSE;
const string                        SlowMaLabel       = "SlowMa";
 
MyMovingAverage                     FastMA;
MyMovingAverage                     SlowMA;

int OnInit() {
 
   IndicatorBuffers( 2 );                    // We have two indicators
   IndicatorDigits( Digits );                // Digits for visualizing their values.
  
   if( ! FastMA.Initialize( FastMaPlotIndex, FastMaPeriod, FastMaShift, FastMaMethod, FastMaPrice, FastMaLabel, DRAW_LINE ) ){
      return INIT_FAILED;
   }
 
   if( ! SlowMA.Initialize( SlowMaPlotIndex, SlowMaPeriod, SlowMaShift, SlowMaMethod, SlowMaPrice, SlowMaLabel, DRAW_LINE ) ){
      return INIT_FAILED;
   }
  
   return INIT_SUCCEEDED;
}

int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
{
 
   FastMA.Compute( rates_total, prev_calculated, open, high, low, close );
   SlowMA.Compute( rates_total, prev_calculated, open, high, low, close );
  
   return(rates_total);
  
}